java: remove explicit jdk setup #917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Nino <jnino@lyft.com>
|
@buildbreaker I noticed you added jdk setup in #877 for javadocs, but I think that might be causing issues now against the example apps: https://github.com/lyft/envoy-mobile/runs/782461117#step:8:70 and what is installed in the github actions mac ci agents |
|
@junr03 We'll likely get another issue but this looks like a proguard issue with android-30? A similar issue a few years back: bazelbuild/bazel#3777 |
|
Likely cause: actions/runner-images#1030? Just to give a little more color onto the jdk specification. macos-latest in github actions uses the latest jdk (14?). After some version (it's like jdk 12 or something), they stopped shipping some tools.jar which javadoc generation jar relies on |
|
Let's try: #918? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jose Nino jnino@lyft.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]